Skip to content

Let connection_lost close the underlying socket #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 12 commits into from
Jul 19, 2021
Merged

Let connection_lost close the underlying socket #918

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c4a17ee
Suppress log backtrace when shutdown during startup
bdraco Jul 19, 2021
acf9d93
Wait for connection_lost
bdraco Jul 19, 2021
1e56a69
Wait for connection_lost
bdraco Jul 19, 2021
5dbb303
Wait for connection_lost
bdraco Jul 19, 2021
91f6633
Wait for connection_lost
bdraco Jul 19, 2021
8029f40
Wait for connection_lost
bdraco Jul 19, 2021
62e1db0
Wait for connection_lost
bdraco Jul 19, 2021
e191af4
Wait for connection_lost
bdraco Jul 19, 2021
4fd471f
let connection lost do it
bdraco Jul 19, 2021
e3090cf
preen
bdraco Jul 19, 2021
460b865
should never throw
bdraco Jul 19, 2021
1602977
black
bdraco Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions zeroconf/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,6 @@ def _async_shutdown(self) -> None:
"""Shutdown transports and sockets."""
for transport in itertools.chain(self.senders, self.readers):
transport.close()
for s in self._respond_sockets:
s.close()

def close(self) -> None:
"""Close from sync context."""
Expand Down Expand Up @@ -328,6 +326,9 @@ def error_received(self, exc: Exception) -> None:
def connection_made(self, transport: asyncio.BaseTransport) -> None:
self.transport = cast(asyncio.DatagramTransport, transport)

def connection_lost(self, exc: Optional[Exception]) -> None:
"""Handle connection lost."""


class Zeroconf(QuietLogger):

Expand Down