Reduce complexity of DNSRecord#915
Merged
Merged
Conversation
Member
bdraco
commented
Jul 18, 2021
bdraco
commented
- Use constants for calculations in is_expired/is_stale/is_recent
- Use constants for calculations in is_expired/is_stale/is_recent
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2327 2313 -14
Branches 387 383 -4
=========================================
- Hits 2327 2313 -14
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.