Skip to content

Disable N818 in flake8#905

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:newflake8_N818
Jul 16, 2021
Merged

Disable N818 in flake8#905
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:newflake8_N818

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 16, 2021

  • We cannot rename these exceptions now without a breaking change
    as they have existed for many years

- We cannot rename these exceptions now without a breaking change
  as they have existed for many years
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #905 (7291021) into master (675fd6f) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #905      +/-   ##
===========================================
- Coverage   100.00%   99.91%   -0.09%     
===========================================
  Files           22       22              
  Lines         2339     2339              
  Branches       390      390              
===========================================
- Hits          2339     2337       -2     
- Misses           0        2       +2     
Impacted Files Coverage Δ
zeroconf/const.py 97.50% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675fd6f...7291021. Read the comment docs.

@bdraco bdraco merged commit f8af0fb into python-zeroconf:master Jul 16, 2021
@bdraco bdraco deleted the newflake8_N818 branch July 16, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants