Added select.error handling to detect closed sockets in Engine.run#88
Closed
someposer wants to merge 1 commit into
Closed
Added select.error handling to detect closed sockets in Engine.run#88someposer wants to merge 1 commit into
someposer wants to merge 1 commit into
Conversation
|
👍 to this, it fixes home-assistant-libs/pychromecast#59 and home-assistant-libs/pychromecast#120 in pychromecast. I'm not sure why the tests failed, but it's flake8 failures in files unrelated to this PR. |
This was referenced Nov 25, 2016
1 similar comment
|
#92 is fixed. The remaining failure is Python 2.6, which has since been dropped. |
jstasiak
added a commit
that referenced
this pull request
Feb 3, 2017
Based on a pull request by someposer[1] (code adapted to work on Python 3). Fixes two pychromecast issues[2][3]. [1] #88 [2] home-assistant-libs/pychromecast#59 [3] home-assistant-libs/pychromecast#120
Collaborator
|
Thanks for the patch, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When closing a zeroconf object, many times an error will be thrown. This error can be seen when running the registration.py example.
$ python examples/registration.py
Registration of a service, press Ctrl-C to exit...
^C
Unregistering...
Exception in thread zeroconf-Engine:
Traceback (most recent call last):
File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
self.run()
File "/usr/local/lib/python2.7/site-packages/zeroconf.py", line 946, in run
rr, wr, er = select.select(rs, [], [], self.timeout)
error: (9, 'Bad file descriptor')