Skip to content

fix: build only the sdist in the release job - #1921

Merged
bdraco merged 1 commit into
masterfrom
release-pure-python-wheel
Sep 28, 2026
Merged

bdraco merged 1 commit into
masterfrom
release-pure-python-wheel

Conversation

@bdraco

@bdraco bdraco commented Sep 28, 2026

Copy link
Copy Markdown
Member

Summary

The release job built a wheel next to the sdist, and that wheel is now tagged linux_x86_64, which PyPI rejects, so 0.151.4 was tagged but never uploaded. The release job now builds the sdist only, all wheels come from the cibuildwheel jobs that run after it.

Test plan

Ran poetry build --format sdist locally, it produces only zeroconf-0.151.4.tar.gz with build_ext.py and the .pxd files included.

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, and may keep LGPL-2.1-or-later as an OR option so GPL-2.0-only projects can keep using the library, see #1835.

By continuing with this pull request you agree that this new contribution is offered under both Apache 2.0 and LGPL-2.1-or-later, so it is covered under either outcome.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under these licenses does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@bdraco
bdraco marked this pull request as ready for review September 28, 2026 14:34
@bdraco
bdraco merged commit 1d939f4 into master Sep 28, 2026
33 of 34 checks passed
@codspeed

codspeed Bot commented Sep 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing release-pure-python-wheel (ad42a78) with master (47ec4ba)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (0c0c935) during the generation of this report, so 47ec4ba was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (47ec4ba) to head (ad42a78).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1921   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3913     3913           
  Branches      568      568           
=======================================
  Hits         3908     3908           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant