fix: build only the sdist in the release job - #1921
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, and may keep LGPL-2.1-or-later as an OR option so GPL-2.0-only projects can keep using the library, see #1835. By continuing with this pull request you agree that this new contribution is offered under both Apache 2.0 and LGPL-2.1-or-later, so it is covered under either outcome. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under these licenses does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3913 3913
Branches 568 568
=======================================
Hits 3908 3908
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
The release job built a wheel next to the sdist, and that wheel is now tagged
linux_x86_64, which PyPI rejects, so 0.151.4 was tagged but never uploaded. The release job now builds the sdist only, all wheels come from the cibuildwheel jobs that run after it.Test plan
Ran
poetry build --format sdistlocally, it produces onlyzeroconf-0.151.4.tar.gzwithbuild_ext.pyand the.pxdfiles included.