chore: restructure the txt parse loop and reword the remaining echoes from the twelfth audit - #1897
Conversation
… from the twelfth audit
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1897 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3911 3911
Branches 568 568
=======================================
Hits 3906 3906
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Follow-up to the twelfth independent audit of the #1835 removal claims: it caught the third
by detailsdocstring the two earlier fixes missed, a TXT parse loop with five statements byte-identical to the 2009setText, and a comment paraphrasing a 2009 changelog line.Details
async_all_by_detailswas the third sibling of the docstring family chore: drop the equality docstring family and reword the cache lookup docstring #1892 and chore: reword the remaining by-details docstring flagged by the eleventh audit #1896 addressed; its first line is reworded the same way, with the thread-safety paragraph untouched._unpack_text_into_propertieswalked its length-prefixed bytes with the 2009 statement sequence (end/index, two separate increments). The loop now slices from a computedstartand advancesposin one step; the operation count is unchanged (three additions per entry either way) and the.pxdlocals are updated in the same commit. Thetest_txt_propertiesCodSpeed benchmark covers this path and will referee it on the PR.add_mcast_question_responsedoes not perform. The comment now states what the code does: the answer also goes out by multicast for a unicast source, and a copy multicast within the last second is folded into the aggregated response per RFC 6762 section 14.A four-agent simplify review ran on this diff: reuse, simplification and efficiency came back clean (the loop is op-count equivalent and the
.pxdtyping follows the repo's unsigned convention); the altitude reviewer caught the inaccurate first version of the comment reword above, which is fixed here.Test plan
REQUIRE_CYTHON=1rebuild: 518 passed.pxdchanged)