Skip to content

chore: restructure the txt parse loop and reword the remaining echoes from the twelfth audit - #1897

Merged
bdraco merged 1 commit into
masterfrom
twelfth_audit_residue
Aug 30, 2026
Merged

bdraco merged 1 commit into
masterfrom
twelfth_audit_residue

Conversation

@bdraco

@bdraco bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the twelfth independent audit of the #1835 removal claims: it caught the third by details docstring the two earlier fixes missed, a TXT parse loop with five statements byte-identical to the 2009 setText, and a comment paraphrasing a 2009 changelog line.

Details

  • async_all_by_details was the third sibling of the docstring family chore: drop the equality docstring family and reword the cache lookup docstring #1892 and chore: reword the remaining by-details docstring flagged by the eleventh audit #1896 addressed; its first line is reworded the same way, with the thread-safety paragraph untouched.
  • _unpack_text_into_properties walked its length-prefixed bytes with the 2009 statement sequence (end/index, two separate increments). The loop now slices from a computed start and advances pos in one step; the operation count is unchanged (three additions per entry either way) and the .pxd locals are updated in the same commit. The test_txt_properties CodSpeed benchmark covers this path and will referee it on the PR.
  • The query handler's multicast comment shared its wording shape with a line from the removed 2009 header changelog, and its old "75% of ttl" parenthetical described a check add_mcast_question_response does not perform. The comment now states what the code does: the answer also goes out by multicast for a unicast source, and a copy multicast within the last second is folded into the aggregated response per RFC 6762 section 14.

A four-agent simplify review ran on this diff: reuse, simplification and efficiency came back clean (the loop is op-count equivalent and the .pxd typing follows the repo's unsigned convention); the altitude reviewer caught the inaccurate first version of the comment reword above, which is fixed here.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • txt properties benchmark passes locally; CodSpeed will confirm no regression
  • pre-commit clean (cython-lint included, since the .pxd changed)

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (07e3812) to head (c3f533e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1897   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing twelfth_audit_residue (c3f533e) with master (011e789)

Open in CodSpeed

@bdraco
bdraco marked this pull request as ready for review August 30, 2026 04:43
@bdraco
bdraco merged commit 716f8d7 into master Aug 30, 2026
37 checks passed
@bdraco
bdraco deleted the twelfth_audit_residue branch August 30, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant