Skip to content

chore: reword the remaining by-details docstring flagged by the eleventh audit - #1896

Merged
bdraco merged 1 commit into
masterfrom
eleventh_audit_residue
Aug 30, 2026
Merged

bdraco merged 1 commit into
masterfrom
eleventh_audit_residue

Conversation

@bdraco

@bdraco bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

The eleventh independent audit of the #1835 removal claims found one docstring #1892 missed: get_by_details still opened with the 2009 "Gets ... by details. Returns None ..." template (0.68 against the 2009 line). Reworded in fresh words; the caller-facing caveat sentences are untouched.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • pre-commit clean

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@bdraco
bdraco marked this pull request as ready for review August 30, 2026 04:14
@bdraco
bdraco merged commit 011e789 into master Aug 30, 2026
32 of 34 checks passed
@bdraco
bdraco deleted the eleventh_audit_residue branch August 30, 2026 04:14
@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing eleventh_audit_residue (0980ba2) with master (07e3812)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (b7aea22) during the generation of this report, so 07e3812 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (07e3812) to head (0980ba2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1896   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant