chore: drop the equality docstring family and reword the cache lookup docstring - #1892
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1892 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3911 3911
Branches 568 568
=======================================
Hits 3906 3906
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you agree that this new contribution is offered under Apache 2.0. This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work. If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase |
1 participant
Summary
Follow-up to the ninth independent audit of the #1835 removal claims: it caught one undisclosed 2009 echo (
DNSCache.get_all_by_details's docstring, 0.77 against the 2009 "Gets an entry by details.") and confirmed the equality docstrings still measure 0.60 to 0.69 against 2009 text despite an earlier claim they were reworded.Details
get_all_by_detailsdocstring was written in 2021 as a variant of the 2009 line; it now describes the lookup in fresh words."""Equal when ... match."""docstrings in_dns.pyare deleted rather than reworded: an__eq__docstring that names the compared fields restates the method body, the repo convention prefers no docstring in that case, and deletion removes the measured similarity for the whole family at once.Test plan
REQUIRE_CYTHON=1rebuild: 518 passed