Skip to content

chore: fix the stale fallback comment and reword docstrings flagged by the eighth audit - #1891

Merged
bdraco merged 1 commit into
masterfrom
eighth_audit_residue
Aug 30, 2026
Merged

chore: fix the stale fallback comment and reword docstrings flagged by the eighth audit#1891
bdraco merged 1 commit into
masterfrom
eighth_audit_residue

Conversation

@bdraco

@bdraco bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to the eighth independent audit of the #1835 removal claims: fixes a stale comment that still described the removed 2009 repr fallback, and rewords three docstrings the audit scored against removed or 2009 text.

Details

  • const.py described the _CLASSES/_TYPES lookup fallback as "?(value)", the 2009 display fallback revert: remove the 2009 record display formats #1878 removed; the comment now names the actual fallback in _dns.py.
  • ServiceInfo.name's docstring measured 0.67 against a removed line; reworded.
  • Two query handler docstrings matched the tail of a 2009 docstring at up to 0.89; reworded.

Test plan

  • full compiled test suite after REQUIRE_CYTHON=1 rebuild: 518 passed
  • pre-commit clean

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you agree that this new contribution is offered under Apache 2.0.

This notice does not affect your previous contributions. If you would like to consent to relicensing those as well, please post the consent statement on #1835; silence is never treated as consent for past work.

If offering this contribution under Apache 2.0 does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request.

@codecov

codecov Bot commented Aug 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (cc92a76) to head (6b26441).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1891   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3911     3911           
  Branches      568      568           
=======================================
  Hits         3906     3906           
  Misses          3        3           
  Partials        2        2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco mentioned this pull request Aug 30, 2026
Open
@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing eighth_audit_residue (6b26441) with master (cc92a76)

Open in CodSpeed

@bdraco
bdraco marked this pull request as ready for review August 30, 2026 02:13
@bdraco
bdraco merged commit 25f564a into master Aug 30, 2026
41 checks passed
@bdraco
bdraco deleted the eighth_audit_residue branch August 30, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@bdraco