Skip to content

chore: refresh changelog prose, metadata and test listener naming - #1884

Merged
bdraco merged 1 commit into
masterfrom
remove_changelog_prose
Aug 30, 2026
Merged

bdraco merged 1 commit into
masterfrom
remove_changelog_prose

Conversation

@bdraco

@bdraco bdraco commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Sixteenth pass for #1835, from a fourth independent audit. The changelog carried mgorny's commit body verbatim (semantic release blamed it, so blame driven scoping never saw it); his entry and eshattow's PR title are rewritten as neutral summaries, and old changelog entries are never regenerated so the edit is stable. The pyproject authors metadata gets the same treatment as __author__ in #1868, with a maintainers field added. The 2009 MyListener test class name is renamed, the DNSRecord docstring no longer opens with the three word 2009 DNSEntry phrase, and the name validator return line is reworded.

Test plan

  • full suite passes; poetry check clean apart from a pre existing dependencies migration warning

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

@bdraco
bdraco marked this pull request as ready for review August 30, 2026 00:04
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (474ed30) to head (5646824).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1884   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3910     3910           
  Branches      568      568           
=======================================
  Hits         3905     3905           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Aug 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing remove_changelog_prose (5646824) with master (474ed30)

Open in CodSpeed

@bdraco
bdraco merged commit fa34dab into master Aug 30, 2026
37 checks passed
@bdraco
bdraco deleted the remove_changelog_prose branch August 30, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant