revert: remove the 2009 record display formats - #1878
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
bdraco
force-pushed
the
remove_2009_repr_formats
branch
from
August 29, 2026 22:59
b4c1266 to
f778828
Compare
This was referenced Aug 29, 2026
bdraco
force-pushed
the
remove_2009_repr_formats
branch
from
August 29, 2026 23:05
ab09b75 to
d84dd4f
Compare
bdraco
force-pushed
the
remove_2009_repr_formats
branch
from
August 29, 2026 23:14
d84dd4f to
5584f3c
Compare
bdraco
marked this pull request as ready for review
August 29, 2026 23:14
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fifteenth removal pass for #1835, from a third independent audit. The record display family in
_dns.pyis a structural port of the 2009 toString family: the hdr[type,class-unique,name]=other layout, the ?(x) fallback, the ttl/remaining prefix, the cpu space os and server colon port arguments. #1872 removed only the DNSText member; this deletes the rest of the family whole (entry_to_string, get_class_, get_type, to_string, the DNSHinfo and DNSService reprs) plus a 2021 comment in the name compressor that paraphrases the 2009 pointer comment. The tree is intentionally red until the follow up lands fresh formats.Test plan