chore: extend the ordering convention to the remaining large classes - #1874
Merged
Merged
Conversation
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 33 33
Lines 3882 3882
Branches 567 567
=======================================
Hits 3877 3877
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second independent audit showed #1867 missed the classes outside
_dns.pyand the protocol writers;Zeroconfin particular kept the 2009 public method sequence intact. This applies the same stated rule (dunders first with__init__pinned, public alphabetical, private alphabetical) toZeroconf,DNSCache,ServiceInfo,ServiceBrowser,_ServiceBrowserBaseandDNSIncoming.Measured with the auditor's metric (ordered LCS over shared snake cased method names vs the 2009 monolith): Zeroconf 0.92 to 0.23, ServiceInfo 1.00 to 0.50, DNSIncoming 0.78 to 0.44, DNSCache 1.00 to 0.75. ServiceBrowser stays at 1.00 because its three shared names happen to sort alphabetically into the 2009 order; the arrangement is rule generated either way.
No behavior changes; pure declaration reordering. pxd files untouched.
Test plan