revert: remove examples and repr inherited from the 2014 browser example - #1872
Merged
Merged
Conversation
bdraco
force-pushed
the
remove_inherited_display_blocks
branch
from
August 29, 2026 22:17
a1ab825 to
fa1e253
Compare
|
Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835. By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0. If that does not work for you, no hard feelings; reply with the exact phrase |
bdraco
changed the title
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1872 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 33 33
Lines 3882 3878 -4
Branches 567 566 -1
==========================================
- Hits 3877 3873 -4
Misses 3 3
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thirteenth removal pass for #1835, from a second independent adversarial audit. Three survivals the blame driven scoping never reached because the carrying files were created in 2021 by copy paste: async_apple_scanner and async_service_info_request carry the property display print block descending character for character from wmcbrine's 2014 browser example, so both example files are deleted whole per the established pattern and come back brand new in the follow up; the readme usage example descends structurally from the 2009 Browser.py through zwebbrowse.py and is deleted here too; and the DNSText repr truncation (show 7 characters when longer than 10) is an arbitrary 2009 choice, deleted with its method.
Test plan