Skip to content

chore: replace the remaining 2009 era path fixture values - #1869

Merged
bdraco merged 1 commit into
masterfrom
replace_path_fixture
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
replace_path_fixture

Conversation

@bdraco

@bdraco bdraco commented Aug 29, 2026 •

Copy link
Copy Markdown
Member

Summary

One more fixture family for #1835 that the earlier sweeps missed: the TXT record test property {"path": "/~paulsm/"} used 116 times across the suite descends from the 2009 fixtures. Replaced with neutral equal length paths so the handful of tests that assert hardcoded TXT length prefix bytes keep passing.

Test plan

  • full suite passes

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

@bdraco
bdraco marked this pull request as ready for review August 29, 2026 21:51
@codspeed

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing replace_path_fixture (f1eb1a3) with master (eb817f1)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (a03ad8b) during the generation of this report, so eb817f1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@bdraco
bdraco merged commit 4307523 into master Aug 29, 2026
36 checks passed
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (a03ad8b) to head (f1eb1a3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1869   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3882     3882           
  Branches      567      567           
=======================================
  Hits         3877     3877           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
bdraco deleted the replace_path_fixture branch August 29, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant