Skip to content

chore: fresh bare pytest tests, de-classed suites and new fixture values - #1866

Merged
bdraco merged 1 commit into
masterfrom
fresh_pytest_tests
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
fresh_pytest_tests

Conversation

@bdraco

@bdraco bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Follow up to #1865 for #1835, addressing the independent adversarial audit. Three parts:

  1. Freshly authored bare pytest replacements for the deleted 2009 descended coverage: parametrized tests for deep label chains, the oversized label rejection, duplicate questions, empty message roundtrips, header flag bits, the multicast zero id, section counts, and question equality.
  2. The remaining class based tests in test_init, test_protocol and test_core are converted to bare pytest functions, which retires the 2009 class names Framework, Names, PacketGeneration and PacketForm; unittest skip decorators became pytest.mark.skipif and one call form pytest.raises became the context manager form. The conftest known blocking nodeid was updated for the de-classing.
  3. The 2009 descended fixture values are replaced across the whole suite: ash-2.local becomes spare-rig.local, the 10.0.1.x address family becomes 10.7.4.x, and testname.local becomes candidate.local.

An AST structure comparison of the fresh tests against the 2009 test file shows only the generic build call parse shape every tiny roundtrip test shares; the class names, method sequence, fixtures and assertion style that identified the port are gone.

Test plan

  • full suite passes (513, fresh parametrized cases replace the deleted methods)
  • fixture sweep confirms no 2009 fixture strings remain

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

@codspeed

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing fresh_pytest_tests (20a39c7) with master (758f5f9)

Open in CodSpeed

@bdraco
bdraco marked this pull request as ready for review August 29, 2026 21:37
@bdraco
bdraco merged commit 7b75536 into master Aug 29, 2026
34 of 35 checks passed
@bdraco
bdraco deleted the fresh_pytest_tests branch August 29, 2026 21:38
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (758f5f9) to head (20a39c7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
+ Coverage   99.81%   99.87%   +0.05%     
==========================================
  Files          33       33              
  Lines        3882     3882              
  Branches      567      567              
==========================================
+ Hits         3875     3877       +2     
+ Misses          4        3       -1     
+ Partials        3        2       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant