Skip to content

chore: fresh docstrings, test name string and workflow step names - #1853

Merged
bdraco merged 1 commit into
masterfrom
restore_char_audit_prose
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
restore_char_audit_prose

Conversation

@bdraco

@bdraco bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Follow up to #1852 for #1835. Adds freshly written class docstrings for the five DNS record classes, rewrites test_long_name with a new test string, and names the two workflow steps fresh. The eighteen test helper docstrings stay deleted per the terse docstring rule.

A four word n-gram comparison against the deleted text shares only the test's API compelled call lines; the character level audit on this branch reports no remaining prose matches.

Test plan

  • full suite passes, test_long_name restored
  • character audit re-run clean on the restored files

Base automatically changed from remove_char_audit_prose to master August 29, 2026 20:00
@bdraco
bdraco force-pushed the restore_char_audit_prose branch from da88b49 to ea54b58 Compare August 29, 2026 20:00
@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

@bdraco
bdraco marked this pull request as ready for review August 29, 2026 20:01
@bdraco
bdraco merged commit 4339329 into master Aug 29, 2026
31 of 32 checks passed
@bdraco
bdraco deleted the restore_char_audit_prose branch August 29, 2026 20:02
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (f01845a) to head (ea54b58).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3882     3882           
  Branches      567      567           
=======================================
  Hits         3877     3877           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing restore_char_audit_prose (ea54b58) with master (0a53e72)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (f01845a) during the generation of this report, so 0a53e72 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant