Skip to content

chore: add freshly written docstrings and async examples - #1848

Merged
bdraco merged 1 commit into
masterfrom
restore_fresh_docstrings
Aug 29, 2026
Merged

bdraco merged 1 commit into
masterfrom
restore_fresh_docstrings

Conversation

@bdraco

@bdraco bdraco commented Aug 29, 2026

Copy link
Copy Markdown
Member

Summary

Follow up to #1847 for #1835. Adds freshly written docstrings for every public member that lost its rendered API documentation in the derivative prose removal, terse one liners for the internal helpers that earn them, and two brand new async example scripts replacing the deleted ones.

Details

  • every docstring here was authored new; a four word n-gram comparison against the deleted text shows no shared prose beyond one generic phrase, and a six word comparison against the 2009 pyzeroconf and 2014 v0.14-wmcbrine trees comes back empty
  • the new examples use asyncio.create_task and asyncio.Event instead of the legacy ensure_future and sleep loops

Test plan

  • full suite passes
  • both examples run under --help and pass ruff
  • verified no public member of zeroconf or zeroconf.asyncio lost documentation relative to master except pre existing gaps

@github-actions

Copy link
Copy Markdown

Thanks for contributing! A quick note: this project is in the process of moving from LGPL-2.1 to Apache 2.0, see #1835.

By continuing with this pull request you are okay with your contribution, and your previous contributions to this repository, being offered under Apache 2.0.

If that does not work for you, no hard feelings; reply with the exact phrase I do not agree to the Apache 2.0 license or simply close this pull request, and nothing of yours will be included in the change.

Base automatically changed from remove_derivative_prose to master August 29, 2026 19:36
@bdraco
bdraco force-pushed the restore_fresh_docstrings branch from cff5f32 to 0d6f3c1 Compare August 29, 2026 19:36
@bdraco
bdraco marked this pull request as ready for review August 29, 2026 19:37
@codspeed

codspeed Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing restore_fresh_docstrings (0d6f3c1) with master (6eabbc3)

Open in CodSpeed

@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.87%. Comparing base (6eabbc3) to head (0d6f3c1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1848   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          33       33           
  Lines        3882     3882           
  Branches      567      567           
=======================================
  Hits         3877     3877           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
bdraco merged commit 82c41e0 into master Aug 29, 2026
35 checks passed
@bdraco
bdraco deleted the restore_fresh_docstrings branch August 29, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant