Skip to content

test: make test_qu_response deterministic by injecting the announcement #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 1 commit into from
Aug 29, 2026
Merged

test: make test_qu_response deterministic by injecting the announcement #1845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,10 @@ def test_qu_response(quick_timing: None) -> None:
"ash-other.local.",
addresses=[socket.inet_aton("10.0.4.2")],
)
# register
zc.register_service(info)
# Register and inject the announcement directly so the cache state is
# deterministic; announcing on loopback would race the phases below.
zc.registry.async_add(info)
_inject_response(zc, r.DNSIncoming(zc.generate_service_broadcast(info, None).packets()[0]))

def _validate_complete_response(answers):
has_srv = has_txt = has_a = has_aaaa = has_nsec = False
Expand Down
Loading