Skip to content

ci: build the asan workflow extensions through poetry install - #1834

Merged
bdraco merged 1 commit into
masterfrom
fix_asan_workflow
Aug 28, 2026
Merged

bdraco merged 1 commit into
masterfrom
fix_asan_workflow

Conversation

@bdraco

@bdraco bdraco commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

The dispatch run failed because setup.py is generated by poetry-core at install time and is not checked in. The fix moves the ASan flags onto poetry install itself; a fresh checkout compiles every extension from scratch, so the instrumentation lands without a separate build step. Verified locally that a clean install with these flags links the ASan runtime into the extensions. The failed run is currently the latest on master, so the asan-status gate blocks CI until this merges and a re-dispatch goes green.

@codspeed

codspeed Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing fix_asan_workflow (3675732) with master (28f8047)

Open in CodSpeed

@bdraco
bdraco force-pushed the fix_asan_workflow branch from 2e7cd7a to 3675732 Compare August 28, 2026 22:18
@bdraco bdraco changed the title ci: generate the setup script in the asan workflow ci: build the asan workflow extensions through poetry install Aug 28, 2026
@bdraco
bdraco merged commit e63bf6f into master Aug 28, 2026
2 checks passed
@bdraco
bdraco deleted the fix_asan_workflow branch August 28, 2026 22:19
@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.86%. Comparing base (28f8047) to head (3675732).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          33       33           
  Lines        3839     3839           
  Branches      553      553           
=======================================
  Hits         3834     3834           
  Misses          3        3           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant