test: fix race in test_get_info_partial - #1826
Merged
Merged
Conversation
bdraco
marked this pull request as ready for review
August 28, 2026 18:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1826 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 33 33
Lines 3772 3799 +27
Branches 536 543 +7
=======================================
+ Hits 3765 3792 +27
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_get_info_partialclearedsend_eventbefore_inject_response, so a query generated from the pre inject cache could satisfy the wait; on a slow runner the second wait then saw a stale query that still asked for TXT and failed withassert 4 == 3, seen on the pypy use_cython job.Details
_inject_responseblocks until the response is processed on the loop, so clearingsend_eventafter it returns guarantees the next captured query was built from the updated cache; any stale send has already set the event and gets discarded by the clearwait_timeis now 2s and the helper timeout 10s, covering the ~1s duplicate question interval when a stale query burns a slotservice_info_eventinstead of timing out onsend_event, so the completion assert does not depend on thread schedulingTest plan
_inject_responsesby 50ms, the old test fails withassert 4 == 3, the fixed test passestests/services/test_info.pypasses with the cython build