ci: don't fail-fast the wheel matrix#1692
Closed
bdraco wants to merge 1 commit into
Closed
Conversation
A single arch's failure was cancelling every other wheel job (see 0.149.0, where one cp39 entry took down the entire build_wheels run and left PyPI with sdist only). Setting `fail-fast: false` lets the other ~30 jobs keep going, so a fix targets just the one broken arch.
Member
Author
|
nah, we want to fail .. better to fail than partial |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3410 3410
Branches 464 464
=======================================
Hits 3402 3402
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
fail-fast: falseto thebuild_wheelsjob's matrix strategy so one arch's failure no longer cancels the other ~30 wheel builds.Motivation
run/25974564348had a single failing entry —Wheels for ubuntu-latest (musllinux) armv7l cp39— and every other arch was cancelled mid-build.upload_pypiwas skipped, so0.149.0landed on PyPI as sdist only. Withfail-fast: false, the other arches would have completed andupload_pypiwould have published whatever the matrix produced; a fix could then re-target just the broken arch.fail-fast: falseis already set on thetestmatrix at line 51 — this just bringsbuild_wheelsin line.Test plan
upload_pypi(which depends onbuild_wheels) still gates correctly. Withfail-fast: false, a single-arch failure meansbuild_wheelsisfailure, soupload_pypiwould still be skipped — same gating behaviour, just better diagnostics on which arch broke.Note
This is a
ci:change, so it's excluded fromsemantic-release's changelog (exclude_commit_patternsinpyproject.toml) and won't bump the version on its own.