fix(ci): drop cp39 from cibuildwheel matrix#1691
Merged
Merged
Conversation
`pyproject.toml` is now `requires-python = ">=3.10"` after #1688, so cibuildwheel refused the explicit `CIBW_BUILD=cp39*` matrix entries with "No build identifiers selected". The cp39 job's failure cancelled the rest of the wheel matrix (no `fail-fast: false` on the matrix), so 0.149.0 reached PyPI as sdist only. Removing the two stale cp39 entries lets the next release publish a full wheel set.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3410 3410
Branches 464 464
=======================================
Hits 3402 3402
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #1688 bumped
requires-pythonto>=3.10, twocp39matrix entries were left behind in the cibuildwheel matrix. cibuildwheel refused them withNo build identifiers selected, the failure cancelled every other arch in the wheel job (nofail-fast: falseon this matrix), and0.149.0reached PyPI as sdist + one stray cp314 wheel only —upload_pypiwas skipped becausebuild_wheelsdidn't complete.Details
Failing job:
Wheels for ubuntu-latest (musllinux) armv7l cp39This PR removes the two stale entries:
ubuntu-latest qemu=armv7l musl=musllinux pyver=cp39ubuntu-latest qemu=armv7l musl="" pyver=cp39The
fix:prefix lets PSR cut0.149.1, so the wheel matrix runs once more andupload_pypipublishes a full cross-arch wheel set to replace the sdist-only0.149.0.Test plan
0.149.1.Wheels for …job completes successfully (no more cancelled arches).0.149.1on PyPI has the full wheel set (manylinux + musllinux x86_64 / aarch64 / armv7l / riscv64, macOS, Windows).Follow-up worth considering
Add
strategy.fail-fast: falseto thebuild_wheelsmatrix so a single arch failure no longer cancels the other ~30 jobs. Happy to do that in a separate PR if you want.