chore(release): keep semantic-release on 0.x series and revert version to 0.148.0#1674
Merged
Merged
Conversation
The 1.0.0 release was unintended and was yanked from PyPI (see the 1.0.0 release notes). The root cause was that master's `[tool.semantic_release]` was missing `allow_zero_version = true`, so when python-semantic-release was upgraded to 10.x the next release computed 0.148.0 -> 1.0.0 instead of staying within the 0.x line. This change brings master's release config in line with the release-0.x branch (commit 812a2b3, 'feat: trigger semantic releases for 0.x branch'): - Add `allow_zero_version = true` so 0.x is treated as the active major and breaking-change commits bump 0.x.y, not 1.0.0. - Add the `release-0.x` branch matcher and exclude it from the `noop` (prerelease) match so future releases off either branch stay in the 0.x line. - Reset `version` in pyproject.toml and `__version__` in src/zeroconf/__init__.py from 1.0.0 back to 0.148.0 (the last intended release) so the next release computes from 0.148.0.
bdraco
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1674 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3401 3401
Branches 461 461
=======================================
Hits 3393 3393
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep master on the 0.x line. The 1.0.0 release was unintended and
was yanked from PyPI; the root cause was that master's
[tool.semantic_release]block was missingallow_zero_version = true,so when python-semantic-release was upgraded to 10.x the next
release computed
0.148.0→1.0.0(treating the 0.x line as"initial development") instead of staying in 0.x.
The
release-0.xbranch already has the correct config — addedin
812a2b3("feat: trigger semantic releases for 0.x branch",#1626). This PR forward-ports that fix to master and resets
master's version pointers back to the last intended release.
Details
pyproject.tomlversion = "0.148.0"(reverted from1.0.0).allow_zero_version = trueunder[tool.semantic_release]so 0.x is treated as the active major; breaking-change commits
bump
0.x.yinstead of jumping to1.0.0.[tool.semantic_release.branches."release-0.x"]matcherand update the
noopregex from(?!master$)→(?!(master|release-0.x)$)so future releases off eitherbranch stay in the 0.x line (and other branches stay
prerelease-only).
src/zeroconf/__init__.py__version__ = "0.148.0"(reverted from1.0.0) so theruntime version string matches.
semantic-releasereadsversion_toml/version_variablesasthe source of truth for the current version and computes the next
version from commits since the previous release. After this PR
merges, the next release from master will be a 0.x bump computed
from
0.148.0plus the conventional-commit history since then.Test plan
pre-commit run --all-filespasses (lint job is justpre-commit/action).test changes — so the test matrix is a no-op.
via
semantic-release version --print(or equivalentdry-run) before merging, since this PR changes release
behaviour.
Notes
1.0.0git tag is left in place as a historical marker;the PyPI release is already yanked.
CHANGELOG.md;semantic-releaseregenerates it on the next release.