Remove AppVeyor and Travis-CI - #95
Merged
ocefpaf merged 1 commit intoMay 3, 2021
Merged
Conversation
ocefpaf
force-pushed
the
remove_appveyor_travis
branch
from
April 19, 2021 20:43
fa77f2b to
4dce335
Compare
Conengmo
reviewed
Apr 20, 2021
Member
Author
I'll have to separate the selenium tests from the rest of the tests b/c they only run on 3.9 for some reason. |
ocefpaf
marked this pull request as draft
April 21, 2021 13:27
ocefpaf
force-pushed
the
remove_appveyor_travis
branch
from
April 21, 2021 19:02
25aa285 to
1e1fe4f
Compare
ocefpaf
force-pushed
the
remove_appveyor_travis
branch
from
April 21, 2021 19:55
0a03f07 to
e8a8e37
Compare
ocefpaf
marked this pull request as ready for review
April 21, 2021 19:55
Member
Author
|
@Conengmo this is ready for review now. The only missing pieces are the coding standards and documentation. I'm working on docs for both folium and branca and coding standards won't be needed if we adopt pre-commit hooks. |
Conengmo
self-requested a review
April 21, 2021 20:13
Conengmo
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add some extra tests on GHA before merging this one.