Skip to content

Added myself to Authors list#758

Merged
tsnoam merged 5 commits intopython-telegram-bot:masterfrom
ihoru:authors
Aug 1, 2017
Merged

Added myself to Authors list#758
tsnoam merged 5 commits intopython-telegram-bot:masterfrom
ihoru:authors

Conversation

@ihoru
Copy link
Copy Markdown
Contributor

@ihoru ihoru commented Jul 30, 2017

Due to this #738

P.S. I didn't do anything with urllib3/util/connection.py, just merged it from upstream... I don't understand, why is it so. If you can recommend anything how to solve this problem, I would be very glad!

@tsnoam
Copy link
Copy Markdown
Member

tsnoam commented Jul 31, 2017

@ihoru
there was a change in the git submodules.
you need to do:
git submodule update --init --recursive
but you first have to revert your changes.

Copy link
Copy Markdown
Member

@tsnoam tsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned above - please revert the git submodules change.

@tsnoam tsnoam added the 📋 pending-reply work status: pending-reply label Jul 31, 2017
This reverts commit a980def.
@ihoru
Copy link
Copy Markdown
Contributor Author

ihoru commented Aug 1, 2017

@tsnoam thank you for your help!
We need to add a note about this to contribution file...

@tsnoam
Copy link
Copy Markdown
Member

tsnoam commented Aug 1, 2017

@ihoru It's in the README but improvements are always welcome.

@ihoru
Copy link
Copy Markdown
Contributor Author

ihoru commented Aug 1, 2017

@tsnoam done #763

@tsnoam tsnoam merged commit b6ef30a into python-telegram-bot:master Aug 1, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-reply work status: pending-reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants