Merged
Conversation
…legram-bot into inlinebots
Closed
tests/test_choseninlineresult.py
Outdated
| result = telegram.ChosenInlineResult.de_json(self.json_dict) | ||
|
|
||
| self.assertEqual(result.result_id, self.result_id) | ||
| self.assertEqual(result.from_user.to_dict(), self.from_user.to_dict()) |
Member
There was a problem hiding this comment.
use self.assertDictEqual instead
Member
Author
There was a problem hiding this comment.
I did not know about this. It's done in other tests like that as well, maybe we can change it in other places as well.
Edit: I confused this with something
Member
|
i see that the coverage had decreased. i couldn't see in travis why (it claims that the files don't exist). on the next CI check lets make sure that the important parts are covered properly. |
Member
Author
|
I think the coverage decreases because there is no test for |
Member
Author
|
Travis is failing due to network errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Telegram Bot API changes from January 4, 2016 and January 14, 2016
Related to #146