Conversation
Visit each argument's annotation so structural searches and replacements can use its source region. Cover the reported wildcard crash, nested annotations, defaults, and source round trips. Based on the diagnosis and proposed fix in issue python-rope#802.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Searching a parameter annotation such as
def foo(items: list): ...raisesAttributeErrorbecause_argleaves the annotation without a source region. Visit the annotation with the existing child-node handler, following v587su's proposed fix in #802.Regression tests cover exact source regions, source round trips, wildcard matching, and an actual
Restructurereplacement of nested annotations with defaults. The change covers regular function arguments.Fixes #802
Checklist
Validation on Windows with Python 3.12.14: all five new regression tests fail against the original module and pass with the fix. Full suite: 2,153 passed, 12 skipped, 5 xfailed. Targeted Black and isort checks pass; wheel and sdist builds pass.