Skip to content

Build failure on macOS with current rapidjson master #166

Closed

Description

@lelit

In v1.7 I updated the underlying rapidjson library, but something went wrong on macOS.

@hynek, @sontek: any chance you are still using macOS and have some insight?

Activity

  1. vtomole commented on Jul 6, 2022

    @vtomole

    We're running into this with the latest release of python-rapidjson as well. https://github.com/SupertechLabs/cirq-superstaq/runs/7220914428?check_suite_focus=true.

  2. lelit commented on Jul 6, 2022

    @lelit
    ContributorAuthor

    I'm sorry about that, I will revert to the previous rapidjson commit, if nothing else emerge.

  3. pavoljuhas commented on Jul 6, 2022

    @pavoljuhas

    The root cause seems to be here - Tencent/rapidjson@9965ab3 - which causes

    ./rapidjson/include/rapidjson/document.h:2498:51: error: found '<::' after a template name which forms the digraph '<:' (aka '[') and a ':', did you mean '< ::'?

  4. lelit commented on Jul 6, 2022

    @lelit
    ContributorAuthor

    Thank you, I commented that commit, but I won't hold my breath waiting an answer... 😭
    Tomorrow I will try to revert either to that commit's parent, or to the previous state.

  5. lelit commented on Jul 7, 2022

    @lelit
    ContributorAuthor

    A comment from the original author of that commit suggested to add -std=c++11, and that did the trick!
    I will release v1.8 asap.

  6. vtomole commented on Jul 7, 2022

    @vtomole

    Very cool, and nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions