Relocate the warning into the documentation.

James William Pye · James William Pye · commit f7cc9d0d659d · 2009-06-12T00:21:37.000-07:00
It was already there, but wasn't as pronounced as it is now.
diff --git a/postgresql/documentation/driver.txt b/postgresql/documentation/driver.txt
@@ -16,10 +16,13 @@ For DB-API 2.0 users, the driver module is located at
 `postgresql.driver.dbapi20`. The DB-API 2.0 interface extends PG-API. All of the
 features discussed in this chapter are available on DB-API connections.
 
-.. note::
+.. warning::
    PostgreSQL versions 8.1 and earlier do not support standard conforming
-   strings. A warning will be raised whenever a connection is established to a
-   server that does not support standard conforming strings.
+   strings. In order to avoid subjective escape methods on connections,
+   `postgresql.driver.pq3` enables the ``standard_conforming_strings`` setting
+   by default. Greater care must be taken when working versions that do not
+   support standard strings.
+   **The majority of issues surrounding the interpolation of properly quoted literals can be easily avoided by using parameterized statements**.
 
 The following identifiers are regularly used as shorthands for significant
 interface elements:
diff --git a/postgresql/driver/pq3.py b/postgresql/driver/pq3.py
@@ -1922,18 +1922,12 @@ def connect(self):
 		# Set standard_conforming_strings
 		scstr = self.settings.get('standard_conforming_strings')
 		if scstr is None or (self.version_info[0] == 8 and self.version_info[1] == 1):
-			# warn about non-standard strings
-			cm = element.ClientNotice(
-				message = 'standard conforming strings are not available',
-				severity = 'WARNING',
-				code = '01-00',
-				hint = 'Backend does not support "SET standard_conforming_strings TO ON"'
-			)
-			cm = self._convert_pq_message(cm)
-			cm.creator = self
-			cm.raise_message()
+			# There used to be a warning emitted here.
+			# It was noisy, and had little added value
+			# over a nice WARNING at the top of the driver documentation.
+			pass
 		elif scstr.lower() not in ('on','true','yes'):
-			self.settings['standard_conforming_strings'] = str(True)
+			self.settings['standard_conforming_strings'] = 'on'
 		super().connect()
 
 	def _pq_push(self, xact, controller = None):
