Commit b712a9b
James William Pye
Simplify and improve client parameter collection.
This changes everything about parameter collection, but it should be infinitely
easier to use and understand than what was previously here. There is still some
work to be done wrt carrying the parameter source with the value, but I think it
may be possible to do that transparently(str subclass, methinks)..
Some bullet points:
- get rid of "path-as-in-search_path" in IRIs. There is still a "path"
component, but it's merely the remainder of the IRIs path after the "database"
component is extracted. Will need to deal with that issue soon.
- clientparameters is now "pluggable". most of the extrapolation that occurs
wrt pq-IRIs, pq-DSNs, and service files is modifiable. It would be possible to
turn off service file usage entirely.
- in the driver, if settings/search_path is not a "str", make it one in the
_startup_parameters by joining the quoted_ident of the items in the iterable.
- clientoptparse changed dramatically and for the better. Most options refer to
a callback and just append the clientparameter pair to the
"db_client_parameters" list on the values. (got a bit of a desire to move
clientoptparse into clientparameters as the output needs some of those
functions to make sense of the data[it's "denormalized"]..)1 parent 2f076bb commit b712a9b
7 files changed
Lines changed: 557 additions & 501 deletions
File tree
- postgresql
- driver
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
0 commit comments