Skip to content

Allow import of multiple packages #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatch merged 3 commits into from
Oct 4, 2020
Merged

Allow import of multiple packages #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55f353e
[feat] parse multiple packages
Oct 4, 2020
d696c20
[tests] add test for multiple tests
Oct 4, 2020
0b13f9f
[style] linting issue
Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions importall/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,26 @@ def main(argv: Optional[List[str]] = None) -> None:
"--exclude", default="tests", help="comma-separated directories to ignore"
)
parser.add_argument("--root", help="Search under this dir")
parser.add_argument("package", metavar="PACKAGE", help="Name of package to test")
parser.add_argument(
"package", nargs="+", metavar="PACKAGE", help="Name of package(s) to test"
)
args = parser.parse_args(argv)

assert "." not in args.package, "give top level package name"
if args.root:
sys.path.insert(0, args.root)

filename = __import__(args.package).__file__
assert filename is not None, "namespace packages not supported"
assert filename.endswith("__init__.py"), "single modules not supported"

exclude_set = set(args.exclude.split(","))
base_path = Path(filename).parent.parent
for name in sorted(find_importable_names(base_path, args.package, exclude_set)):
__import__(name)
print(f"{name} ok")

for package in args.package:
assert "." not in package, f"{package}: give top level package name"

filename = __import__(package).__file__
assert filename is not None, f"{package}: namespace packages not supported"
assert filename.endswith(
"__init__.py"
), f"{package}: single modules not supported"

base_path = Path(filename).parents[1]
for name in sorted(find_importable_names(base_path, package, exclude_set)):
__import__(name)
print(f"{name} ok")
22 changes: 21 additions & 1 deletion importall/tests/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_no_root(self) -> None:
output,
)

def test_ok(self) -> None:
def test_single_modules_ok(self) -> None:
with volatile.dir() as d:
pd = Path(d)
(pd / "fake_module").mkdir()
Expand All @@ -65,6 +65,26 @@ def test_ok(self) -> None:
"""\
fake_module ok
fake_module.x ok
""",
output,
)
self.assertEqual(None, err)

def test_multiple_modules_ok(self) -> None:
with volatile.dir() as d:
pd = Path(d)
(pd / "fake_module_1").mkdir()
(pd / "fake_module_1" / "__init__.py").write_text("")

(pd / "fake_module_2").mkdir()
(pd / "fake_module_2" / "__init__.py").write_text("")

output, err = self.do_run([f"--root={d}", "fake_module_1", "fake_module_2"])

self.assertEqual(
"""\
fake_module_1 ok
fake_module_2 ok
""",
output,
)
Expand Down