Repository navigation
Take more than one top-level package #1
Description
Right now you can only pass a single top-level package, which is parsed out as args.package.
In order to specify more than one (and also make things more testable), the body in main should be moved to another function, and called for each package. https://docs.python.org/3/library/argparse.html#nargs documents the nargs which will need to change to "+" for the package argument.
- Set up a development environment
cd /path/to/importall
make venv
source .venv/bin/activate
make test
- Make the changes you want to, probably in
importall/main.py - Manually test with e.g.
python -m importall click importall --exclude '_winconsole.py'
- Add an automated test in
importall/tests/main.py - Submit a PR!
Activity
thatch commentedon Oct 4, 2020
@markrofail Thanks so much for the fix! Looks like we forgot to assign this to you before closing; I'm trying an
@-mention here to see if you show in the list afterward.markrofail commentedon Oct 4, 2020
Thank you for reviewing and merging the PR @thatch . However, I will not receive credit until you add "hacktoberfest" topic to your repository.
thatch commentedon Oct 4, 2020
I think you're good to go now!