fix localization setting url - #938
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
=======================================
Coverage 11.30% 11.30%
=======================================
Files 625 625
Lines 71915 71915
=======================================
Hits 8132 8132
Misses 63783 63783 Continue to review full report at Codecov.
|
Contributor
|
will merge, as not sure what makes the most sense here (trailing slash or none?), but could also be fixed in urls where there is a clear indication which would be preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #937 .
Is this a bugfix or an enhancement?
bugfix
Proposed changes:
Checklist:
much simpler if this is kept separate from functional changes]
If an enhancement (or non-trivial bugfix):