remove invalid wx sizer flags - #1707
Open
barentine wants to merge 11 commits into
Open
Conversation
…nsliders hardcoded to 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1706 and follow-ons from #1705. Also capitalized an
Linwx.HORIZONTALso it resolves even though it isn't used.Is this a bugfix or an enhancement?
bugfix on later wxwidgets/wxpython
Proposed changes:
follow-on from #1705 , using a Claude-coded parse of our source code to look for invalid wx sizer flags. Added the check as a unit test to prevent us from doing this in the future.
Remove horizontal sizer flags on horizontal sizers, align with expand, etc.
Checklist:
Not all of these have been tested, but I spot checked several and they crash us out like #1705 does on
wxpython 4.2.5 py311h8325047_2 conda-forge
wxwidgets 3.2.9 h34c1157_0 conda-forge
(spot checked 3 files fixes, mentioned in commit messages, by removing the fix and hitting the bug through the GUI)
Notes:
Some of these are tough to test at the moment because they exist in code which is never called. Some things we might want to just remove include
LaserControlFrame.pyandIntegrationSliders.IntegrationSliders_. Several others under e.g. if False statements. But with the test hitting them as failures I added them as fixes.