wxpython 4.3.x compatibility for DisplayOptionsPanel.py - #1690
Merged
Conversation
…ise debug message internally calls strftime which currently crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
PYMEImage -tfails to load on the new wxpython 4.3.1 release.In wxpython 4.3 StaticBoxSizer parents are more strict, and at least warn with debug messages. We earn ourselves a debug message in
DisplayOptionsPanel.py, but for some reason that debug call fails and we fail to open PYMEImage:Fix is to make the static box the parent of the widgets, rather than the panel.
Tested fix on wxpython 4.3.1 and 4.2.5