add test for recipe localization modules coordinate conventions - #1663
add test for recipe localization modules coordinate conventions#1663barentine wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <[email protected]>
|
Coordinates in general could use a bit of a work-over - it's a bit more than just nm vs pixels, it's nm (roi referenced), nm (origin referenced), or pixels. Pixels is the most forgiving if the data comes from a source where it might be missing some metadata , but is also the least powerful. |
|
I wonder about adding some sort of units awareness to tabular, and letting it handle conversions (so if you had a column |
|
I do think baking in more unit awareness would be helpful rather than harmful. For example the change to have Separately, I wonder whether there are other ways to bring |
|
Having a bit of a think about what we'd really need to make this work in tabular. To be robust we'd need to track: type: (initially, None or "coordinate" / position) This feels quite heavy for the tabular class when it applies to 3 columns but not to others. Serialising to hdf will be fine (or rather we can find a way to make it work), serialising to csv / excel will loose all the metadata. I'm not saying we shouldn't do it, but just that we should think a bit about how. One possible approach (albeit with high breaking change potential) is to actually change anything that currently writes |
I'm PR'ing this as a draft to show a test I think we should have, and to raise as an issue the coordinate convention headache that one might hit if they do a couple of localization processes using recipe modules.
Namely:
Would love to hear some thoughts on preferred way to fix some of these @David-Baddeley !
My thought would be to: