Plugin factory - building on PR #1524 - #1590
Closed
csoeller wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
This would need revisiting with the newer build guidelines for setuptools etc so closing for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a debugged and ever so slightly tweaked version of PR #1524.
Is this a bugfix or an enhancement?
More like enhancement although mostly a smallish bugfix of PR #1524.
The plugin factory approach presented in PR #1524 seems compelling but would not run. This version has been debugged and very slightly tweaked using
argparse.BooleanOptionalActionwhich requires a recent Python version (3.9+ I believe) but at this stage I think we demand versions in this range with latest PYME releases in any case.The PR could alternatively have been raised against
David_Baddeley/python-microscopywhich is still entirely possible if preferred, important to mention that all credits should go to @David-Baddeley for the idea and implementation. Please provide guidance in the comments if that is the preferred route.It seems sensible to get this PR integrated into the dist ahead of the bigger task of updating the PYME build system (see also #1562) so that it can be considered during that upgrade for generating plugins compatible with the new build system.
Proposed changes:
#1524 was not running as is and with some testing everything now appears to work in this version.
Usage is
with a few possible options, i.e.
Checklist:
Checked with recent git versions of PYME. Seems to generate and then install plugins fine with current PYME.