Skip to content

ppolicy control documentation#397

Merged
encukou merged 1 commit into
python-ldap:masterfrom
azmeuk:doc
Dec 4, 2020
Merged

ppolicy control documentation#397
encukou merged 1 commit into
python-ldap:masterfrom
azmeuk:doc

Conversation

@azmeuk
Copy link
Copy Markdown
Member

@azmeuk azmeuk commented Nov 18, 2020

I just noticed that the ppolicy control did not appear in the documentation.

Attributes are auto-documented with sphinx autoattribute

For module data members and class attributes, documentation can either be put into a comment [...] or in a docstring after the definition.

Comment thread Doc/conf.py Outdated
Comment thread Lib/ldap/controls/ppolicy.py
Comment thread Lib/ldap/controls/ppolicy.py Outdated
Copy link
Copy Markdown
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me!
Good catch with the decodeControlValue method!

@encukou encukou merged commit 7dfa21a into python-ldap:master Dec 4, 2020
@encukou
Copy link
Copy Markdown
Member

encukou commented Dec 4, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants