Add logo and images to README#432
Merged
eriknw merged 2 commits intopython-graphblas:mainfrom Apr 16, 2023
Merged
Conversation
Member
SultanOrazbayev
left a comment
SultanOrazbayev
left a comment
There was a problem hiding this comment.
Looks great, Erik! :)
eriknw
commented
Apr 16, 2023
Comment on lines
+12
to
+17
| <defs | ||
| id="defs130" /> | ||
| <g | ||
| id="g715" | ||
| style="fill:#ff0000" | ||
| transform="translate(-9.9602331,-10.294627)" /> |
Member
Author
There was a problem hiding this comment.
@jim22k is it safe to remove these lines? Do they do anything? Do they help inkscape in any way? They look delete-able to me.
Member
Author
|
Thanks for looking @SultanOrazbayev! Merging. We can always make tweaks as desired. I wouldn't mind if the graph diagram looked a little better... |
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to try to make the README more attractive.
I made a new version of the "python-graphblas" logo that is twice as large and hopefully looks okay in both dark and light mode.
I added images of a graph and the corresponding adjacency matrix as shown by our notebook repr.
I added these images to MANIFEST so they will show on PyPI.
I link to
graphblas-algorithms.I broke the badges up into three lines.
And, finally, I'm playing around with https://pre-commit.ci which may be able to replace our lint CI action.