Conversation
|
It would be nice to have this merged before the next release. 🙂 |
`merge_config()` supports other options that the constructor and `from_config()` factory method do, and was just missing this one.
677e698 to
1b3cb2f
Compare
|
@nickbroon Could we have some tests for this as well? |
Are there any existing tests of |
Replying to myself; There are no immediately obviously existing tests, or even uses, of |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Explicit False values currently cannot override a configuration value of True.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds retry_transient_errors handling to Gitlab.merge_config().
Changes:
- Merges the retry setting from explicit options or configuration.
| File | Description |
|---|---|
gitlab/client.py |
Passes the merged retry setting to the client constructor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| retry_transient_errors=options.get("retry_transient_errors") | ||
| or config.retry_transient_errors, |
There was a problem hiding this comment.
Does the existing ssl_verify config option must also have this same behaviour?
merge_config()supports other options that the constructor andfrom_config()factory method do, and was just missing this one.