refactor: pre-commit triggered from tox#2320
Merged
nejch merged 1 commit intopython-gitlab:mainfrom Oct 20, 2022
Merged
Conversation
Member
|
I personally don't like this as I do NOT use pre-commit. I like to do everything in tox. And I do not want to use pre-commit. |
lmilbaum
force-pushed
the
refactoring
branch
3 times, most recently
from
b6f5bf3 to
dd7730e
Compare
Author
Good point. I should have raised this topic in a discussion. |
lmilbaum
force-pushed
the
refactoring
branch
9 times, most recently
from
29cafad to
ca5b6a7
Compare
lmilbaum
changed the title
nejch
reviewed
Oct 19, 2022
lmilbaum
force-pushed
the
refactoring
branch
2 times, most recently
from
0042e7a to
214c2d7
Compare
lmilbaum
changed the title
nejch
reviewed
Oct 19, 2022
JohnVillalovos
approved these changes
Oct 20, 2022
Member
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
This works for me. As I usually run a subset of the tox checks in my development process.
I like that I don't have to run pre-commit and can just use tox 🙂
So I approve but let @nejch do the merging if he approves.
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project is using two liniting frameworks: tox and pre-commit. Each has its own configuration files and a CI workflow.
The purpose of this PR is to consolidate linting into one framework: tox
Discussion - #2321
This PR is a baby step towards a full transition