chore: change name of API functional test to api_func_v4 - #2147
Merged
Merged
Conversation
JohnVillalovos
marked this pull request as draft
July 15, 2022 01:45
JohnVillalovos
marked this pull request as ready for review
July 15, 2022 01:57
Member
Author
|
@nejch Not sure what you think about this. I'm fine to drop it but just thought I liked the naming consistency. |
The CLI test is `cli_func_v4` and using `api_func_v4` matches with that naming convention.
JohnVillalovos
force-pushed
the
jlvillal/api_func_v4
branch
from
July 18, 2022 05:24
9adef8a to
8cf5cd9
Compare
Member
|
Thanks @JohnVillalovos - yes, this one has annoyed me for a while as well. :) We'll just need to change required checks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI test is
cli_func_v4and usingapi_func_v4matches withthat naming convention.