Feature/project merge request approval rules#1200
Conversation
robinson96
force-pushed
the
feature/project_merge_request_approval_rules
branch
from
84b4735 to
c6fbf39
Compare
robinson96
changed the title
|
Hi @robinson96 thanks for the MR! Would you mind to add some docs and tests to this? I can't really test EE features, but I will take a look based on your docs! |
I will certainly add docs. I too lack a great way to do EE testing, I develop GRAPE, which has some features for maintaining pull requests. It works in that context. (branch unfortunately is on a repo hosting service that is not public). |
|
@max-wittig , I'm trying to find test_merge_requests.py so I can modify it to add appropriate tests, but am coming up short. (My python testing skills are still developing). Any hints on where to be looking? (tools/functional/api/ only has a few of the files that Travis appears to be exercising...) |
|
Our unittests are here: https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects And functional tests are here: https://github.com/python-gitlab/python-gitlab/tree/master/tools/functional/api For this, it's only possible to add unit tests, as we run the functional tests against GitLab Core |
Thanks. Tests are added! |
@max-wittig - any other concerns with this PR? |
max-wittig
left a comment
max-wittig
left a comment
There was a problem hiding this comment.
Ah yes sorry I forgot to press the submit review button
| approver_group_ids=[653, 654]) | ||
| approver_group_ids=[653, 654]) | ||
|
|
||
| Create a new MR-level approval rule or Change existing MR-level approval rule:: |
There was a problem hiding this comment.
| Create a new MR-level approval rule or Change existing MR-level approval rule:: | |
| Create a new MR-level approval rule or change an existing MR-level approval rule:: |
|
@max-wittig - any other concerns? |
|
@max-wittig - any other concerns with this branch? |
|
thanks for the PR and sorry for the time it took to merge |
|
@max-wittig - no worries and thanks for walking me through it! |
2 participants
Addresses #1199.