fix: Update __exit__ method to use Optional types#733
Open
AustinZhang1024 wants to merge 3 commits into
Open
Conversation
belono
approved these changes
Jun 7, 2026
Contributor
There was a problem hiding this comment.
Hi @AustinZhang1024 !
From contextmanager.__exit__(exc_type, exc_val, exc_tb)
If an exception occurred while executing the body of the with statement, the arguments contain the exception type, value and traceback information. Otherwise, all three arguments are
None.
You are right, if no exception is raised when exiting a context manager then all three arguments will be None, so their types should be Optional.
Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 81.90% 81.90%
=======================================
Files 21 21
Lines 1708 1708
Branches 267 267
=======================================
Hits 1399 1399
Misses 230 230
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From the newest document, better to allow
Nonein the type hint.This will fix the invalid-context-manager error of ty.
Tested with
Windows 11