Skip to content

New feature: Software columns - Part 4: Examples - #673

Merged
patkan merged 4 commits into
python-escpos:masterfrom
belono:software_columns_examples
Feb 21, 2025
Merged

New feature: Software columns - Part 4: Examples#673
patkan merged 4 commits into
python-escpos:masterfrom
belono:software_columns_examples

Conversation

@belono

@belono belono commented Jan 25, 2025

Copy link
Copy Markdown
Contributor

Description

This is part 4 and last in the series on implementing software columns.

This adds the software_columns.py file to the 'examples' folder containing some simple usage examples.

@codecov

codecov Bot commented Jan 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.29%. Comparing base (0a1d384) to head (45c4a29).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          21       21           
  Lines        1679     1679           
  Branches      262      262           
=======================================
  Hits         1365     1365           
  Misses        234      234           
  Partials       80       80           
Flag Coverage Δ
unittests 80.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@belono
belono force-pushed the software_columns_examples branch from c4a1c9e to a562454 Compare January 25, 2025 19:46
@belono
belono marked this pull request as ready for review January 25, 2025 19:53
@belono

belono commented Feb 19, 2025

Copy link
Copy Markdown
Contributor Author

@patkan should I split 08dbe5d into a separate PR as it affects/fixes the CI pipeline of other PRs?

Otherwise, this one should be merged in first place. Right?

Comment thread examples/software_columns.py
Comment thread examples/software_columns.py Outdated
@patkan

patkan commented Feb 21, 2025

Copy link
Copy Markdown
Member

@belono thank you, looks good to me and I do not see any benefit in splitting this PR :-)

@patkan
patkan merged commit 3e85256 into python-escpos:master Feb 21, 2025
@belono
belono deleted the software_columns_examples branch February 21, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants