New feature: Software columns - Part 3: Tests - #651
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 78.72% 81.12% +2.39%
==========================================
Files 21 21
Lines 1669 1669
Branches 303 303
==========================================
+ Hits 1314 1354 +40
+ Misses 274 233 -41
- Partials 81 82 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
belono
marked this pull request as ready for review
July 19, 2024 21:15
patkan
approved these changes
Aug 24, 2024
patkan
left a comment
patkan
left a comment
Member
There was a problem hiding this comment.
Thank you! Nothing to add from my side :-)
|
Cool feature! It would be nice if it was available in the PyPi package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part 3 of the series on implementing software columns.
This adds some simple tests to the battery of tests.
Tested with
My local pytest suite