New feature: Software columns - Part 2: CLI - #649
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 21 21
Lines 1669 1669
Branches 303 303
=======================================
Hits 1314 1314
Misses 274 274
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
belono
force-pushed
the
software_columns_cli
branch
from
July 13, 2024 16:45
0040f4a to
27235f9
Compare
belono
force-pushed
the
software_columns_cli
branch
from
July 13, 2024 16:57
56e1022 to
311b235
Compare
belono
marked this pull request as ready for review
July 14, 2024 09:09
patkan
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part 2 of the series on implementing software columns.
This enables the CLI to accept the new
software_columnssub-command with the arguments--text_list,--widthsand--aligncorresponding to the same method name and params in the API.Tested with
Epson TM-U210