Improve CASv2 XML parsing when response is not standard - #4
Merged
Merged
Conversation
mingchen
pushed a commit
that referenced
this pull request
Aug 3, 2018
Improve CASv2 XML parsing when response is not standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so I was quietly configuring a CAS connection for one of our client when suddenly this XML response was returned to me:
<?xml version="1.0" encoding="UTF-8"?> <cas:serviceResponse xmlns:cas="http://www.yale.edu/tp/cas"><cas:authenticationSuccess><cas:utilisateur><cas:displayName>John Doe</cas:displayName><cas:user>someuser</cas:user><cas:uid>someuser</cas:uid></cas:utilisateur></cas:authenticationSuccess></cas:serviceResponse>Our beloved client use a custom version of CAS which nests the
cas:usernode inside a nicecas:utilisateurnode.I don't know if it has its place in the main repository, but here is a pull request that cope with this case by looking for the
cas:usernode in the whole tree and not just in the children ofcas:authenticationSuccess.Best regards !