Skip to content

Allow bug creation with an explicitly empty list of groups #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crobinso merged 1 commit into from
Sep 4, 2024
Merged

Allow bug creation with an explicitly empty list of groups #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bugzilla/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,7 @@ def build_createbug(self,
localdict["cc"] = listify(cc)
if depends_on:
localdict["depends_on"] = listify(depends_on)
if groups:
if groups is not None:
localdict["groups"] = listify(groups)
if keywords:
localdict["keywords"] = listify(keywords)
Expand Down
20 changes: 20 additions & 0 deletions tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from bugzilla.base import Bugzilla


def test_build_createbug():
bz = Bugzilla(url=None)

args = {"product": "Ubuntu 33⅓", "summary": "Hello World", "alias": "CVE-2024-0000"}
result = bz.build_createbug(**args)
assert result == args

result = bz.build_createbug(groups=None, **args)
assert result == args

args["groups"] = []
result = bz.build_createbug(**args)
assert result == args

args["groups"] += ["the-group"]
result = bz.build_createbug(**args)
assert result == args