setup: pylint: Enable protected-access check

crobinso · crobinso · commit f40370a2023b · 2014-04-21T13:15:40.000-04:00
diff --git a/bugzilla/bug.py b/bugzilla/bug.py
@@ -70,8 +70,11 @@ def __getattr__(self, name):
                 # have never been called.
                 return self.__dict__[name]
 
-            # Check field aliases
-            for newname, oldname in self.bugzilla._get_bug_aliases():
+            # pylint: disable=protected-access
+            aliases = self.bugzilla._get_bug_aliases()
+            # pylint: enable=protected-access
+
+            for newname, oldname in aliases:
                 if name == oldname and newname in self.__dict__:
                     return self.__dict__[newname]
 
@@ -100,8 +103,10 @@ def refresh(self, extra_fields=None):
         '''
         Refresh the bug with the latest data from bugzilla
         '''
+        # pylint: disable=protected-access
         r = self.bugzilla._getbug(self.bug_id,
             extra_fields=self._bug_fields + (extra_fields or []))
+        # pylint: enable=protected-access
         self._update_dict(r)
     reload = refresh
 
@@ -113,7 +118,11 @@ def _update_dict(self, newdict):
         if self.bugzilla:
             self.bugzilla.post_translation({}, newdict)
 
-            for newname, oldname in self.bugzilla._get_bug_aliases():
+            # pylint: disable=protected-access
+            aliases = self.bugzilla._get_bug_aliases()
+            # pylint: enable=protected-access
+
+            for newname, oldname in aliases:
                 if not oldname in newdict:
                     continue
 
diff --git a/setup.py b/setup.py
@@ -144,11 +144,6 @@ def _run(self):
             # R0201: Method could be a function
             "--disable R0201 "
 
-            # Would be nice to disable these 2 but it just
-            # ain't work reorganizing the code to not trigger them
-            # W0212: Access to a protected member of a client class
-            "--disable W0212 "
-
             "bugzilla/ bin-bugzilla tests/*.py ")
 
         os.system("pep8 --format=pylint "
diff --git a/tests/createbug.py b/tests/createbug.py
@@ -77,7 +77,8 @@ def testMultiOpts(self):
         )
 
     def testFieldConversion(self):
-        out = self.bz._validate_createbug(product="foo", component="bar",
+        vc = self.bz._validate_createbug  # pylint: disable=protected-access
+        out = vc(product="foo", component="bar",
             version="12", description="foo", short_desc="bar",
             check_args=False)
         self.assertDictEqual(out,
diff --git a/tests/rw_functional.py b/tests/rw_functional.py
@@ -615,7 +615,8 @@ def test11UserUpdate(self):
         email = "anaconda-maint-list@redhat.com"
         group = "fedora_contrib"
 
-        if not self._check_have_admin(bz, sys._getframe().f_code.co_name):
+        fn = sys._getframe().f_code.co_name  # pylint: disable=protected-access
+        if not self._check_have_admin(bz, fn):
             return
 
         user = bz.getuser(email)
@@ -654,12 +655,14 @@ def test11ComponentEditing(self):
             "component": component,
         }
 
-        if not self._check_have_admin(bz, sys._getframe().f_code.co_name):
+        fn = sys._getframe().f_code.co_name  # pylint: disable=protected-access
+        if not self._check_have_admin(bz, fn):
             return
 
 
         def compare(data, newid):
-            products = bz._proxy.Product.get({"names": [basedata["product"]]})
+            proxy = bz._proxy  # pylint: disable=protected-access
+            products = proxy.Product.get({"names": [basedata["product"]]})
             compdata = None
             for c in products["products"][0]["components"]:
                 if int(c["id"]) == int(newid):
@@ -700,7 +703,9 @@ def compare(data, newid):
 
     def test12SetCookie(self):
         bz = self.bzclass(url=self.url, cookiefile=cf)
-        if not self._check_rh_privs(bz, sys._getframe().f_code.co_name):
+
+        fn = sys._getframe().f_code.co_name  # pylint: disable=protected-access
+        if not self._check_rh_privs(bz, fn):
             return
 
         try:

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ def testMultiOpts(self):`
`77`	`77`	`)`
`78`	`78`
`79`	`79`	`def testFieldConversion(self):`
`80`		`- out = self.bz._validate_createbug(product="foo", component="bar",`
	`80`	`+ vc = self.bz._validate_createbug # pylint: disable=protected-access`
	`81`	`+ out = vc(product="foo", component="bar",`
`81`	`82`	`version="12", description="foo", short_desc="bar",`
`82`	`83`	`check_args=False)`
`83`	`84`	`self.assertDictEqual(out,`